Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 1165 [Verify configure.ac and source code CURL_DISABLE_-sync] failing #8384

Closed
MarcelRaad opened this issue Feb 4, 2022 · 2 comments
Closed

Test 1165 [Verify configure.ac and source code CURL_DISABLE_-sync] failing #8384

MarcelRaad opened this issue Feb 4, 2022 · 2 comments
Assignees
@bagder
Labels
build

Comments

@MarcelRaad
Copy link
Member

I did this

Look at the autobuilds at https://curl.se/dev/builds.html.

I expected the following

All green :-)
Instead, test 1165 was failing with

Present in configure.ac, not used by code: CURL_DISABLE_NTLM
Documented, but not used by code: CURL_DISABLE_NTLM

The last usage of CURL_DISABLE_NTLM was removed with 1bf3643#diff-9f7d1f1e2f497cabfc05b279c04b116f9213b2f2ea8f6b4c4ec795252fd1905e.

curl/libcurl version

master

operating system

all
@bagder
Copy link
Member

bagder commented Feb 4, 2022

It is still used in code.

curl/lib/curl_setup.h

Line 630 in a6e9196

#if !defined(CURL_DISABLE_CRYPTO_AUTH) && !defined(CURL_DISABLE_NTLM)

I'm not sure why this test fails on some systems...

@bagder bagder added the build label Feb 4, 2022
@bagder bagder self-assigned this Feb 4, 2022
@bagder
Copy link
Member

bagder commented Feb 4, 2022

I just realized why... PR pending.

bagder added a commit that referenced this issue Feb 4, 2022
@bagder
tests/disable-scan.pl: properly detect multiple symbols per line
ade4099 
Test 1165 would fail on some systems because it didn't detect
CURL_DISABLE_* symbols that were used to the right of another one on the
same line! The script would only detect and extract the first one.

Reported-by: Marcel Raad
Fixes #8384
@bagder bagder mentioned this issue Feb 4, 2022
Closed
@bagder bagder closed this as completed in 60d076c Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagder bagder

Labels
build
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests/disable-scan.pl: properly detect multiple symbols per line curl/curl
2 participants
@bagder @MarcelRaad