-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
"schannel: failed to retrieve ALPN result" when running on Windows 7 #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I figure this means we shouldn't try to use ALPN on anything before 8.1? Have you tried to add a check that can switch off |
According to MS, ALPN has been introduced with Windows 8.1. It is not available in Windows 7, so it should be disabled on these systems. We have not tried to do this depending on the Windows version. What we're trying right now is to set |
Yeah, that sounds like a functional work-around. Another one would be to rebuild libcurl with a TLS backend that supports ALPN on win 7 as well, but if you can live without APLN I guess your approach is the easier one. We should still get a fix for this done. |
Confirm everything above. I've got a minimal test case running that shows the following result
where patched means adding the following in our application code:
all builds are done using MSVS 2015 on Windows Server 2012 R2. Given we have a nice workaround now, the question is weather or not this compile time feature check is sufficient. This causes the default behavior that code compiled on Windows 8+ does not run on Windows 7 (and below). |
I'd like to make clear that we use Windows Server 2012 R2, which is based on Windows 8.1 and which is the oldest version that supports ALPN. Windows Server 2012 (without R2) is based on Windows 8 and does not support ALPN. |
It is not. There should be a runtime check in the schannel TLS code that disables ALPN if it is running on Windows < 8.1. I could have a shot at implementing this in the next few days, but I'm not sure that it will be today or tomorrow. @bagder Do you intend to release a bug fix version when this is done? |
Sure, once we have a bug fix it'll get merged and should be included in the pending next release. |
Calling QueryContextAttributes with SECPKG_ATTR_APPLICATION_PROTOCOL fails on Windows < 8.1, so we need to disable ALPN on these OS versions. Fixes curl#840
My apologies for the regression here. I was fairly certain I had tested this on Windows 7 when I implemented #724, but apparently did not. |
I did this
We built libcurl with Visual Studio 2015 on Windows Server 2012 R2 (based on Windows 8.1) and linked it statically to an app that downloads a file via HTTP/1.1. This app was then executed on Windows 7. It failed with this error when trying to download this file:
(see also #724, where ALPN support for schannel has been introduced)
Suspected root cause
The error occurs when libcurl calls QueryContextAttributes in schannel.c. This function has a minimum supported OS version of Windows 8.1 or Server 2012 R2. It is not guaranteed to work on older versions, like Windows 7 (where it fails when called with
SECPKG_ATTR_APPLICATION_PROTOCOL
).I expected the following
The download should have succeeded.
curl/libcurl version
7.49.1 (all is well with 7.48.0)
operating system
The text was updated successfully, but these errors were encountered: