Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error related to ngtcp2-DEV (passed 9 arguments, but takes just 7) #8638

Closed
jurisuk opened this issue Mar 26, 2022 · 2 comments
Closed

Compile error related to ngtcp2-DEV (passed 9 arguments, but takes just 7) #8638

jurisuk opened this issue Mar 26, 2022 · 2 comments
Labels
build HTTP/3

Comments

@jurisuk
Copy link

@jurisuk jurisuk commented Mar 26, 2022

Today, whilst compiling curl together with most recent version of ngtcp2-DEV, encountered this compile error:

  CC       vauth/libcurl_la-gsasl.lo
  CC       vauth/libcurl_la-ntlm.lo
  CC       vauth/libcurl_la-oauth2.lo
  CC       vtls/libcurl_la-openssl.lo
  CC       vtls/libcurl_la-sectransp.lo
  CC       vtls/libcurl_la-vtls.lo
  CC       vquic/libcurl_la-ngtcp2.lo
vquic/ngtcp2.c: In function ‘qs_disconnect’:
vquic/ngtcp2.c:896:45: error: macro "ngtcp2_conn_write_connection_close" passed 9 arguments, but takes just 7
  896 |                                           ts);
      |                                             ^
In file included from vquic/ngtcp2.c:26:
/var/build-staticlib/ngtcp2/include/ngtcp2/ngtcp2.h:5433: note: macro "ngtcp2_conn_write_connection_close" defined here
 5433 | #define ngtcp2_conn_write_connection_close(CONN, PATH, PI, DEST, DESTLEN,      \
      |
vquic/ngtcp2.c:891:8: error: ‘ngtcp2_conn_write_connection_close’ undeclared (first use in this function); did you mean ‘ngtcp2_pkt_write_connection_close’?
  891 |   rc = ngtcp2_conn_write_connection_close(qs->qconn, NULL, /* path */
      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |        ngtcp2_pkt_write_connection_close
vquic/ngtcp2.c:891:8: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [Makefile:3001: vquic/libcurl_la-ngtcp2.lo] Error 1
make[2]: Leaving directory '/var/build-git2/curl/lib'
make[1]: *** [Makefile:1343: all] Error 2
make[1]: Leaving directory '/var/build-git2/curl/lib'
make: *** [Makefile:1218: all-recursive] Error 1
@bagder bagder added build HTTP/3 labels Mar 26, 2022
@bagder
Copy link
Member

@bagder bagder commented Mar 26, 2022

I believe it was changed in this ngtcp2 commit: ngtcp2/ngtcp2@90da093 ... and curl isn't updated yet to match.

@jurisuk
Copy link
Author

@jurisuk jurisuk commented Mar 26, 2022

That's what I thought. No worries. I am patient. 😉👏🏻

bagder added a commit that referenced this issue Mar 26, 2022
Reported-by: jurisuk on github
Fixes #8638
bagder added a commit that referenced this issue Mar 26, 2022
Assisted-by: Tatsuhiro Tsujikawa
Reported-by: jurisuk on github
Fixes #8638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build HTTP/3
Projects
None yet
Development

No branches or pull requests

2 participants