-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build error on macos+gcc #8846
Comments
Versions overlap, so compile check or something like this may fix the issue reliably. |
Sorry, I don't understand at all. Neither why this suddenly is a problem somewhere nor what the proposed fix is. |
There is a build error. |
You can't build the Secure Transport code with GCC, because GCC (so far as I understand) does not support Grand Central Dispatch, and both If you build it with LLVM, then it will work. If you want to patch this so it'll build using non-GCD-supporting compilers, then please file a pull request, and I'll review it. Thanks. |
|
The FSF's GCC does not support GCD at all. There may be third-party forks that have support; if they do, then And now I remember why I had to do that: the code uses old-school availability checks (that is, checking to see if the function is defined at runtime) for weak-linking purposes, and not the newer |
SecTrustEvaluateAsync() is defined in the macOS 10.7 SDK, but it requires Grand Central Dispatch to be supported by the compiler, and some third-party macOS compilers do not support Grand Central Dispatch. SecTrustCopyPublicKey() is not present in macOS 10.6, so this shouldn't adversely affect anything. Fixes curl#8846 Reported-by: Egor Pugin
@nickzman Compare, for example: |
There is a long history of this issue.
https://github.com/curl/curl/issues?q=is%3Aissue+SecTrustEvaluateAsync+is%3Aclosed
curl 7.83.1
macos sdk12.3, gcc11 from homebrew
Error:
Changing it to SecTrustEvaluateWithError (not deprecated) fixes the issue.
You can compare OS version support with SecTrustEvaluateAsync.
SecTrustEvaluate works as well, but it's also deprecated.
The text was updated successfully, but these errors were encountered: