Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure: disable headers api #9134

Closed
MAntoniak opened this issue Jul 11, 2022 · 2 comments
Closed

Configure: disable headers api #9134

MAntoniak opened this issue Jul 11, 2022 · 2 comments
Assignees
Labels

Comments

@MAntoniak
Copy link
Contributor

@MAntoniak MAntoniak commented Jul 11, 2022

I did this

I'm trying build curl v7.84.0 without headers api, so I'm using --disable-headers-api flag in configure script. Unfortunately, I have the following information:

configure: Configured to build curl/libcurl:

Host setup: i686-pc-linux-android
Install prefix: /usr/local/tmp/lib/android/x86
Compiler: /usr/local/src/android-ndk-r23c/toolchains/llvm/prebuilt/linux-x86_64/bin/i686-linux-android27-clang
CFLAGS: -Qunused-arguments -Wno-pointer-bool-conversion -g -Os -pedantic -Wall -Wextra -Wpointer-arith -Wwrite-strings -Wshadow -Winline -Wnested-externs -Wmissing-declarations -Wmissing-prototypes -Wno-long-long -Wfloat-equal -Wno-multichar -Wsign-compare -Wundef -Wno-format-nonliteral -Wendif-labels -Wstrict-prototypes -Wdeclaration-after-statement -Wcast-align -Wno-system-headers -Wshorten-64-to-32 -Wunused -Wvla -Wshift-sign-overflow -Wmissing-variable-declarations -Wdouble-promotion -Wcomma -Wassign-enum -Wextra-semi-stmt
CPPFLAGS: -isystem /usr/local/tmp/lib/android/x86/include
LDFLAGS: -L/usr/local/tmp/lib/android/x86/lib
LIBS: -lssl -lcrypto -lssl -lcrypto

curl version: 7.84.0
SSL: enabled (OpenSSL)
......
Headers API: enabled (--disable-headers-api)
......

I expected the following

Headers API: disabled (--enable-headers-api)

@jzakrzewski
Copy link
Contributor

@jzakrzewski jzakrzewski commented Jul 11, 2022

I am no expert in autotools but aren't those cases simply in the wrong order (meaning '*' always matches before anything else)?:

curl/configure.ac

Lines 4052 to 4069 in 1d5b7b7

dnl ************************************************************
dnl switch on/off headers-api
dnl
AC_MSG_CHECKING([whether to support headers-api])
AC_ARG_ENABLE(headers-api,
AS_HELP_STRING([--enable-headers-api],[Enable headers-api support])
AS_HELP_STRING([--disable-headers-api],[Disable headers-api support]),
[ case "$enableval" in
*)
AC_MSG_RESULT(yes)
;;
no) AC_MSG_RESULT(no)
curl_headers_msg="no (--enable-headers-api)"
AC_DEFINE(CURL_DISABLE_HEADERS_API, 1, [disable headers-api])
;;
esac ],
AC_MSG_RESULT(yes)
)

@MAntoniak
Copy link
Contributor Author

@MAntoniak MAntoniak commented Jul 11, 2022

This may be a good way but it still doesn't work (checked with --disable-headers-api and --enable-headers-api=no option).
The problem may also be if you disable HTTP support (I'm not sure, it's just a guess).

bagder added a commit that referenced this issue Jul 12, 2022
Fixes #9134
Reported-by: Michał Antoniak
@bagder bagder self-assigned this Jul 12, 2022
@bagder bagder closed this as completed in 60be90d Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants