Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test 3026...[curl_global_init thread-safety] failure #9141

Closed
SukanyaHanumanthu opened this issue Jul 12, 2022 · 9 comments
Closed

test 3026...[curl_global_init thread-safety] failure #9141

SukanyaHanumanthu opened this issue Jul 12, 2022 · 9 comments
Assignees
Labels

Comments

@SukanyaHanumanthu
Copy link

@SukanyaHanumanthu SukanyaHanumanthu commented Jul 12, 2022

Test 3026 failed in Curl 7.84.0, fails on linux

test 3026...[curl_global_init thread-safety]

lib3026 returned 255, when expecting 0
 exit FAILED
== Contents of files in the log/ dir after test 3026
=== Start of file commands.log
 ./libtest/lib3026 none >log/stdout3026 2>log/stderr3026
=== End of file commands.log
=== Start of file ftpserver.cmd
 Testnum 3026
=== End of file ftpserver.cmd
=== Start of file stderr3026
 URL: none
 lib3026.c:59 Have pthread but the CURL_VERSION_THREADSAFE feature flag is not set
=== End of file stderr3026

Looks like this commit introduced the error, Is there a fix?

@bagder
Copy link
Member

@bagder bagder commented Jul 12, 2022

How did you build curl? Did you by any chance use cmake to do it?

@SukanyaHanumanthu
Copy link
Author

@SukanyaHanumanthu SukanyaHanumanthu commented Jul 12, 2022

Did the below as we applied a minor patch to multihandle.h

    make && \
    make test-full && \
    make install

@bagder
Copy link
Member

@bagder bagder commented Jul 12, 2022

but how did you generate the makefile?

bagder added a commit that referenced this issue Jul 12, 2022
Reported-by: Sukanya Hanumanthu
Fixes #9141
@bagder
Copy link
Member

@bagder bagder commented Jul 12, 2022

When curl is built with cmake, it is not threadsafe see #8982 for pending work on that

@bagder bagder self-assigned this Jul 12, 2022
@SukanyaHanumanthu
Copy link
Author

@SukanyaHanumanthu SukanyaHanumanthu commented Jul 12, 2022

Used GNUMake for the above and not cmake, is it a known incompatibility?

@bagder
Copy link
Member

@bagder bagder commented Jul 12, 2022

but before make you invoked configure or cmake surely?

@SukanyaHanumanthu
Copy link
Author

@SukanyaHanumanthu SukanyaHanumanthu commented Jul 12, 2022

  • removed cmake which was part of the install script and tested which had no change in behaviour, just an unwanted line.
  • correct about the configure part, which had the below lines before make test
        --disable-shared \
        --with-pic \
        --without-ssl \
        --without-zlib && \

Does this affect the test?

@bagder
Copy link
Member

@bagder bagder commented Jul 12, 2022

Well, now you're complicating this issue. I think you now see "no difference" because you didn't properly rebuild everything after you changed from cmake to configure. Also, do you really want --without-ssl ? It is very unusual.

The fix for the original issue you submitted has been proposed in #9142 though.

@SukanyaHanumanthu
Copy link
Author

@SukanyaHanumanthu SukanyaHanumanthu commented Jul 12, 2022

Thank you for the above, configure was present before/after removing the cmake (configure was always there), though cmake was installed on linux (removed now and tested), it was never used and had no influence, the code always used GNU Make only with configure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants