Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outdated] [Bug] "--trace" hexdump view did not escape "\x7F" #9162

Closed
MasterInQuestion opened this issue Jul 15, 2022 · 10 comments
Closed

[Outdated] [Bug] "--trace" hexdump view did not escape "\x7F" #9162

MasterInQuestion opened this issue Jul 15, 2022 · 10 comments

Comments

@MasterInQuestion
Copy link

@MasterInQuestion MasterInQuestion commented Jul 15, 2022

    As displayed in [ https://github.com/curl/curl/issues/9160#issue-1305810315 ].
    I suppose it's unintended. As the behavior seems to be inconsistent with `hexdump`.

@vszakats vszakats changed the title [Bug] "--trace" hexdump view did not escape "\x7F" [Bug] --trace hexdump view did not escape \x7F Jul 16, 2022
vszakats added a commit to vszakats/curl that referenced this issue Jul 16, 2022
0x7f is `DEL`, a non-printable symbol, so print it as
`UNPRINTABLE_CHAR`.

Reported-by: MasterInQuestion on github
Fixes curl#9162
Closes #xxxx
vszakats added a commit to vszakats/curl that referenced this issue Jul 16, 2022
`0x7F` is `DEL`, a non-printable symbol, so print it as
`UNPRINTABLE_CHAR`.

Reported-by: MasterInQuestion on github
Fixes curl#9162
Closes #xxxx
@vszakats
Copy link
Member

@vszakats vszakats commented Jul 17, 2022

Thank you @MasterInQuestion, it should be fixed now.

@MasterInQuestion MasterInQuestion changed the title [Bug] --trace hexdump view did not escape \x7F [Outdated] [Bug] "--trace" hexdump view did not escape "\x7F" Jul 18, 2022
@MasterInQuestion
Copy link
Author

@MasterInQuestion MasterInQuestion commented Jul 19, 2022

=== Off-Topic ===

    There's semantic difference between "`" (Grave Accent) (U+0060, 0x60, `) and `"` (Quotation Mark) (U+0022, 0x22, ").
    .
    E.g.
    |*| `\x7F` means:
(Character Sequence)
[[
|1| `\` (Reverse Solidus) (U+005C, 0x5C, \)
|2| "x" (Latin Small Letter X) (U+0078, 0x78, x)
|3| "7" (Digit 7) (U+0037, 0x37, 7)
|4| "F" (Latin Capital Letter F) (U+0046, 0x46, F)
]]
    |*| "\x7F" means "\x7F" (Delete) (U+007F, 0x7F, ).

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 19, 2022

It's a Markdown markup here, meaning to display it as code.

@MasterInQuestion
Copy link
Author

@MasterInQuestion MasterInQuestion commented Jul 19, 2022

    I know. And such sophisticated markup creates general interoperability issue.
    See [ https://github.com/curl/curl/issues/9153#issuecomment-1185051870 ].

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 19, 2022

Speaking of GitHub Issues, I think it's the opposite.

@MasterInQuestion
Copy link
Author

@MasterInQuestion MasterInQuestion commented Jul 19, 2022

    For GitHub yet has broken rendering on some very fundamental thing.
    .
    What's the purpose of all these sophisticated markups if things may be very well clearly expressed in Plain Text?

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 19, 2022

The purpose of it is to make posts easier to read and harder to misunderstand. For example code markup will retain spaces and other things. It also indicates that it is code/command/input/output, or a keyword. Yet it remains readable as plain text as well.

@MasterInQuestion
Copy link
Author

@MasterInQuestion MasterInQuestion commented Jul 19, 2022

    The crucial problem is that such significant information become lost when copying (from the rendered display) back into Plain Text.
    Which made general parsing / exchanging bothersome.

@vszakats
Copy link
Member

@vszakats vszakats commented Jul 19, 2022

You can always access the original text for your own submissions. For others, you can do the same with the "Quote reply" option, if that's necessary.

@MasterInQuestion
Copy link
Author

@MasterInQuestion MasterInQuestion commented Jul 19, 2022

    Not always (e.g. locked topic). And the practice is bothersome (not only login required, and the apparent more).
    Even if so:

    Readable in one way, unreadable in another:
    The doomed fate of Markdown, and similar sophisticated markups:
    That demand sophisticated post-rendering to be properly displayed.

@curl curl locked and limited conversation to collaborators Jul 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants