Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Outdated] [Suggestion] "--doh-url" should not assert "http://" when omitted protocol #9163

Closed
MasterInQuestion opened this issue Jul 15, 2022 · 1 comment
Closed

[Outdated] [Suggestion] "--doh-url" should not assert "http://" when omitted protocol #9163

MasterInQuestion opened this issue Jul 15, 2022 · 1 comment
Labels
name lookup DNS and related tech

Comments

@MasterInQuestion
Copy link

MasterInQuestion commented Jul 15, 2022 •
edited
Loading

    DNS over HTTPS hence only HTTPS would be plausible.
    It's value handling should be special-cased.

    Also, would it be proper to add an option "--doh" simply as the alias for "--doh-url"?
    Or perhaps making "--doh" a boolean switch controlling whether to use DoH or not?
vszakats added a commit to vszakats/curl that referenced this issue Jul 16, 2022
@vszakats
doh: use https protocol by default
b272062 
The only allowed protocol is https, so it makes sense to use that
by default if not passed explicitly by the user.

Fixes curl#9163
Closes #xxxx
@vszakats vszakats mentioned this issue Jul 16, 2022
Closed
@vszakats vszakats changed the title [Suggestion] "--doh-url" should not assert "http://" when omitted protocol [Suggestion] --doh-url should not assert http:// when omitted protocol Jul 16, 2022
@vszakats vszakats added the name lookup DNS and related tech label Jul 16, 2022
@vszakats
Copy link
Member

Thanks for your report @MasterInQuestion. Fixed now.

Regarding --doh, discussions are welcome here, or even better in a new Issue dedicated for it.

@MasterInQuestion MasterInQuestion changed the title [Suggestion] --doh-url should not assert http:// when omitted protocol [Outdated] [Suggestion] "--doh-url" should not assert "http://" when omitted protocol Jul 18, 2022
@MasterInQuestion MasterInQuestion mentioned this issue Jul 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
name lookup DNS and related tech
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doh: use https protocol by default vszakats/curl
2 participants
@vszakats @MasterInQuestion