-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS CI jobs fail HTTP/2 tests 1700 + 1701 #9364
Comments
Curious: I first ran it successfully with: libcurl/7.85.0-DEV (SecureTransport) OpenSSL/3.0.5 zlib/1.2.11 brotli/1.0.9 zstd/1.5.2 c-ares/1.18.1 libidn2/2.3.3 nghttp2/1.48.0 librtmp/2.3 Then I ran 'brew upgrade' and now it fails, with: libcurl/7.85.0-DEV (SecureTransport) OpenSSL/3.0.5 zlib/1.2.11 brotli/1.0.9 zstd/1.5.2 c-ares/1.18.1 libidn2/2.3.3 nghttp2/1.49.0 librtmp/2.3 nghttp2/1.49.0 is the change. Also of course, since the h2 tests uses 'nghttpx' from the nghttp2 package, that was probably updated as well... |
but it doesn't say what header |
llhttp which nghttpx uses for HTTP/1.x tightens validation on header field separator and it now only accepts CR + LF. |
Ok. #9365 is the attempted fix for those two tests |
Prior to this change some tests that rely on nghttpx proxy did not use CRLF headers everywhere. Recent changes in nghttp2 (??? ref here) requires curl's HTTP/1.1 test server to use CRLF headers. Fixes curl#9364 Closes #xxxx
Prior to this change some tests that rely on nghttpx proxy did not use CRLF headers everywhere. A recent change in nghttp2, which updated its version of llhttp (HTTP parser), requires curl's HTTP/1.1 test server to use CRLF headers. Ref: nghttp2/nghttp2@9d389e8 Fixes curl/curl#9364 Closes curl/curl#9365
Since a few days back, most (all?) of them fail. example log
The text was updated successfully, but these errors were encountered: