Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test 972 failure leads to test 973 failure #9563

Closed
MarcelRaad opened this issue Sep 21, 2022 · 1 comment
Closed

Test 972 failure leads to test 973 failure #9563

MarcelRaad opened this issue Sep 21, 2022 · 1 comment
Labels
tests

Comments

@MarcelRaad
Copy link
Member

I did this

Look at the Solaris autobuilds, like
https://curl.se/dev/log.cgi?id=20220921085805-1968482#prob9

I expected the following

A green test 973. Instead, it failed because of extra output from test 972, which had previously failed.

curl/libcurl version

9eec754 (see autobuilds)

operating system

Solaris 10
@bagder
Copy link
Member

bagder commented Sep 21, 2022

Curios, the <precheck> command outputs sh: jsonlint-php: not found but does not return error, so curl continues anyway.

Then that leads to the noted follow-up problem...

bagder added a commit that referenced this issue Sep 21, 2022
@bagder
test972: verify the output without using external tool
7f07858 
It seems too restrictive to assume and use an external tool to verify
the JSON. This now verifies the outut byte per byte. We could consider
buildint a local "JSON verifyer" in a future.

Reported-by: Marcel Raad
Fixes #9563
@bagder bagder mentioned this issue Sep 21, 2022
Closed
bagder added a commit that referenced this issue Sep 21, 2022
@bagder
test972: verify the output without using external tool
bfe127e 
It seems too restrictive to assume and use an external tool to verify
the JSON. This now verifies the outut byte per byte. We could consider
building a local "JSON verifyer" in a future.

Reported-by: Marcel Raad
Fixes #9563
@bagder bagder closed this as completed in fb11e45 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test972: verify the output without using external tool curl/curl
2 participants
@bagder @MarcelRaad