Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcurl.plist file contains '-DEV' in version string since 7.83.0 #9866

Closed
jvreelanda opened this issue Nov 8, 2022 · 0 comments
Closed
Assignees
Labels

Comments

@jvreelanda
Copy link

jvreelanda commented Nov 8, 2022

I did this

Downloaded a curl release at version after 7.83.0 and checked the version strings.

I expected the following

To see a version in the libcurl.plist without -DEV it seems to be stripped from the other instances of the version string in curl.

diff ./curl-7.82.0/lib/libcurl.plist  ./curl-7.83.0/lib/libcurl.plist
18c18
< 	<string>7.82.0</string>
---
> 	<string>7.83.0-DEV</string>
30c30
< 	<string>libcurl 7.82.0</string>
---
> 	<string>libcurl 7.83.0-DEV</string>
33c33
< 	<string>libcurl.plist 7.82.0</string>
---
> 	<string>libcurl.plist 7.83.0-DEV</string>

I believe it started with this commit:

git tag --contains e498a9b1fe5964a18eb2a3a99dc52160d2768261
curl-7_83_0
curl-7_83_1
curl-7_84_0
curl-7_85_0
curl-7_86_0

commit e498a9b1fe5964a18eb2a3a99dc52160d2768261
Author: Daniel Gustafsson <daniel@yesql.se>
Date: Wed Apr 20 15:26:13 2022 +0200

 macos: set .plist version in autoconf

 Set the libcurl version in libcurl.plist like how libcurl.vers is
 created.

 Closes: #8692
 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
 Reviewed-by: Nick Zitzmann <nickzman@gmail.com>

curl/libcurl version

7.83.0+

operating system

N/A

Thanks!

@bagder bagder self-assigned this Nov 8, 2022
@bagder bagder added the build label Nov 8, 2022
bagder added a commit that referenced this issue Nov 8, 2022
Follow-up to e498a9b

Make sure the tarball gets a version of the libcurl.plist file that is
updated with the new version string.

Reported-by: jvreelanda on github
Fixes #9866
@bagder bagder closed this as completed in 43232b5 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants