You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.
In lib/url.c the calls to Curl_idnconvert_hostname were moved to parseurlandfillconn() which is called before create_conn_helper_init_proxy in create_conn.
While we are not using libidn2, Curl_idnconvert_hostname is where the dispname member of struct hostname is populated.
Since the calls are gated by conn->bits.httpproxy/conn->bits.socksproxy, the names are not converted since the bits are only set in create_conn_helper_init_proxy.
I'm not sure how to resolve this and still maintain the changes for HSTS needed for that commit, otherwise I'd propose a patch.
Regression: in commit 53bcf55 we moved the IDN conversion calls to
happen before the HSTS checks. But the HSTS checks are only done on the
server host name, not the proxy names. By moving the proxy name IDN
conversions, we accidentally broke the verbose output showing the proxy
This change moves back the IDN conversions for the proxy names to the
place in the code path they were before 53bcf55.
Reported-by: Andy Stamp