Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
HTTP/2 uploads larger than 2^64 bytes aren't reliable #996
Labels
Comments
|
I'm sure you're technically correct but are you saying there's a use case for over 16 exabytes? When I've touched http2.c I've never accounted for that... |
|
Maybe, maybe not. It just struck me that the solution I went with has this limitation and it is easy to fix so I figured it is still worth it. I can imagine use cases where you for example stream video or something in a virtually never-ending stream. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I did this
Send an upload to a server using HTTP/2 without the size set before-hand. (If the size is set, it is limited to 64bit.) due to the logic that still decreases the "upload left" counter even when the size is unknown, it may reach zero accidentally after 2^64 bytes have been transferred even if the transfer hasn't actually ended.
I expected the following
curl should allow the upload stream to go on forever.
curl/libcurl version
all
operating system
all
Note: I have a patch in progress for this already, but I'm holding it off until after the pending release to give it more time to mature.