Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cookie: open cookie jar as a binary file #10017

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Dec 2, 2022

On Windows there is a difference and for text files, ^Z means end of file which is not desirable.

Ref: #9973

On Windows there is a difference and for text files, ^Z means end of
file which is not desirable.

Ref: #9973
@jay
Copy link
Member

jay commented Dec 2, 2022

This change means that CR \r won't be stripped from the end of lines.

@bagder
Copy link
Member Author

bagder commented Dec 2, 2022

This change means that CR \r won't be stripped from the end of lines.

They are already stripped explicitly by cookie.c code though, so it might just work...

@bagder bagder closed this in 73d6f41 Dec 2, 2022
@bagder bagder deleted the bagder/cookie-binary branch December 2, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants