base64: encode without snprintf: a 29x speedup#10026
Closed
Conversation
For speed
jay
approved these changes
Dec 4, 2022
jay
reviewed
Dec 4, 2022
jay
approved these changes
Dec 4, 2022
|
You can remove line 41, we don't need the |
bagder
changed the title
bagder
changed the title
Contributor
|
Great work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For speed
Test setup
https://gist.github.com/bagder/baee5725e09a5977ef5b0471e2b3334f
Measurements
Best out three runs on my machine.
Old code: 5m55.291
New code: 12.254 seconds
A 28.99 times speedup.