Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.mk: improve a GNU Make hack [ci skip] #10031

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Dec 4, 2022

Replace the hack of using $() to represent a single space. The new method silences the --warn-undefined-variables debug warning and it's also a better-known form of solving this problem.

Closes #xxxxx

Replace the hack of using `$() ` to represent a single space. The new
method avoids the `--warn-undefined-variables` debug warning.

Closes #xxxxx
@vszakats vszakats added the build label Dec 4, 2022
@@ -324,7 +324,7 @@ ifdef WIN32
_LIBS += -lws2_32 -lcrypt32 -lbcrypt
endif

ifneq ($(findstring 11,$(subst $() ,,$(SSLLIBS))),)
ifneq ($(findstring 11,$(subst $(subst ,, ),,$(SSLLIBS))),)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would something like $(space) work

Copy link
Member Author

@vszakats vszakats Dec 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of such built-in function. We can initialize such variable using the same hack, but I'd only do it once we have another place which needs a space at a tricky location.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. It would be easier to understand IMO but that's not critical.

jay
jay approved these changes Dec 4, 2022
@vszakats vszakats closed this in 2b584ff Dec 5, 2022
@vszakats vszakats deleted the mk-tidy-1 branch December 5, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants