Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl.h: name all public function parameters #10036

Closed
wants to merge 1 commit into from

Conversation

ryandesign
Copy link
Contributor

Most public function parameters already have names; this adds those that were missing.


I took the parameter names from where the functions were defined in the C sources. In some cases this does not match the documentation. For example, in lib/slist.c (and, with this PR, in curl.h) the second parameter of curl_slist_append is called data while in the documentation it's called string.


My motivation for making these changes arose when I wrote a script to parse the curl headers in part to get the public function parameter names and I noticed a few functions didn't have them. Do you have any objections to adding these?

Most public function parameters already have names; this adds those
that were missing.
bagder
bagder approved these changes Dec 6, 2022
@bagder bagder closed this in d502270 Dec 6, 2022
@bagder
Copy link
Member

bagder commented Dec 6, 2022

Thanks!

@ryandesign ryandesign deleted the ryandesign-param-names branch December 6, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants