Partially revert "somewhat protect Mac OS X users from using Mac OS 9 config file"#10037
Closed
ryandesign wants to merge 1 commit intocurl:masterfrom
Closed
Partially revert "somewhat protect Mac OS X users from using Mac OS 9 config file"#10037ryandesign wants to merge 1 commit intocurl:masterfrom
ryandesign wants to merge 1 commit intocurl:masterfrom
Conversation
… config file" This reverts part of commit 62519bf. Do things that are specific to classic Mac OS (i.e. include config-mac.h in curl_setup.h and rename "main" to "curl_main" in tool_setup.h) when only "macintosh" is defined. Remove the additional condition that "__MRC__" should be defined since that would only be true with the MPW MrC compiler which prevents the use of other reasonable compilers like the MPW SC compiler and especially the Metrowerks CodeWarrior compilers. "macintosh" is only defined by classic Mac OS compilers so this change should not affect users of Mac OS X / OS X / macOS / any other OS.
Contributor
Author
|
Please feel free to edit my commit messages as needed. |
bagder
approved these changes
Dec 6, 2022
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Since this is an ancient commit being reverted, I think the commit message better just explain the change without caring about it being a revert.
I'll edit that as I merge!
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts part of commit 62519bf.
Do things that are specific to classic Mac OS (i.e. include config-mac.h in curl_setup.h and rename
maintocurl_mainin tool_setup.h) when onlymacintoshis defined. Remove the additional condition that__MRC__should be defined since that would only be true with the MPW MrC compiler which prevents the use of other reasonable compilers like the MPW SC compiler and especially the Metrowerks CodeWarrior compilers.macintoshis only defined by classic Mac OS compilers so this change should not affect users of Mac OS X / OS X / macOS / any other OS.The first line of the commit message is markedly longer than 50 characters. I wasn't sure if there was a recommended way to truncate it when reverting a commit like this, or if I should use a more descriptive first line that doesn't mention the reversion.