Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noproxy: guard against empty hostnames in noproxy check #10057

Closed

Conversation

danielgustafsson
Copy link
Member

When checking for a noproxy setting we need to ensure that we get a hostname passed in. If there is no hostname then there cannot be a matching noproxy rule for it by definition.

A larger, independent of this patch, body of work is to ensure that we don't check for proxy information at all on protocols where it doesn't make sense.

When checking for a noproxy setting we need to ensure that we get
a hostname passed in. If there is no hostname then there cannot be
a matching noproxy rule for it by definition.

Closes: #xxxx
Reported-by: Geeknik Labs
bagder
bagder approved these changes Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants