socks: fix username max size is 255 (0xFF)#10105
Closed
0x0a0d wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
danielgustafsson
approved these changes
Dec 16, 2022
Member
danielgustafsson
left a comment
danielgustafsson
left a comment
There was a problem hiding this comment.
Agreed, this looks like a correct fix. Seems like commit f4b6901 got the username length check wrong but the password length check right.
bagder
approved these changes
Dec 16, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl/lib/socks.c
Lines 681 to 687 in 50e781d