Skip to content

Support for Request Payload with msh3#10136

Closed
nibanks wants to merge 1 commit intocurl:masterfrom
nibanks:msh3-request-send-support
Closed

Support for Request Payload with msh3#10136
nibanks wants to merge 1 commit intocurl:masterfrom
nibanks:msh3-request-send-support

Conversation

@nibanks
Copy link
Copy Markdown
Contributor

@nibanks nibanks commented Dec 22, 2022

This updates the msh3 HTTP/3 code to support sending request data. A few option issues that can probably be handled in future PRs:

  • How do we make sure curl doesn't free the send data before the send is complete?
  • How do we know when to FIN the request?
    • Currently, we only will support a single send call from curl and FIN after that.

@bagder bagder added the HTTP/3 h3 or quic related label Dec 22, 2022
@bagder
Copy link
Copy Markdown
Member

bagder commented Dec 27, 2022

"This branch cannot be rebased due to conflicts"

Can you rebase this against master and force-push?

@nibanks
Copy link
Copy Markdown
Contributor Author

nibanks commented Dec 27, 2022

I merged master but it still is complaining?

@nibanks nibanks force-pushed the msh3-request-send-support branch from f0964f7 to 764e98f Compare December 27, 2022 16:03
@nibanks
Copy link
Copy Markdown
Contributor Author

nibanks commented Dec 27, 2022

Ok. Just force pushed. I think I fixed everything.

@bagder bagder closed this in ae98b85 Dec 28, 2022
@bagder
Copy link
Copy Markdown
Member

bagder commented Dec 28, 2022

Thanks!

@nibanks nibanks deleted the msh3-request-send-support branch December 28, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

2 participants