Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Request Payload with msh3 #10136

Closed
wants to merge 1 commit into from
Closed

Support for Request Payload with msh3 #10136

wants to merge 1 commit into from

Conversation

nibanks
Copy link
Contributor

@nibanks nibanks commented Dec 22, 2022

This updates the msh3 HTTP/3 code to support sending request data. A few option issues that can probably be handled in future PRs:

  • How do we make sure curl doesn't free the send data before the send is complete?
  • How do we know when to FIN the request?
    • Currently, we only will support a single send call from curl and FIN after that.

@bagder bagder added the HTTP/3 h3 or quic related label Dec 22, 2022
@bagder
Copy link
Member

bagder commented Dec 27, 2022

"This branch cannot be rebased due to conflicts"

Can you rebase this against master and force-push?

@nibanks
Copy link
Contributor Author

nibanks commented Dec 27, 2022

I merged master but it still is complaining?

@nibanks
Copy link
Contributor Author

nibanks commented Dec 27, 2022

Ok. Just force pushed. I think I fixed everything.

@bagder bagder closed this in ae98b85 Dec 28, 2022
@bagder
Copy link
Member

bagder commented Dec 28, 2022

Thanks!

@nibanks nibanks deleted the msh3-request-send-support branch December 28, 2022 13:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
HTTP/3 h3 or quic related
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nibanks @bagder