Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the trace message "Mark bundle... multiuse" #10159

Closed

Conversation

drok
Copy link
Contributor

@drok drok commented Dec 26, 2022

The message "Mark bundle as not supporting multiuse" was added at commit 29364d9 when an http/2-related bug was fixed, and it appears to be a leftover trace message.

This message should be removed because:

  • it conveys no information to the user
  • it is enabled in the default build (--enable-verbose)
  • it reads like a warning/unexpected condition
  • it is equivalent to "Detected http proto < 2", which is not a useful message.
  • it is a time-wasting red-herring for anyone who encounters it for the first time while investigating some other, real problem.

This commit removes the trace message "Mark bundle as not supporting multiuse"

The message "Mark bundle as not supporting multiuse" was added at commit
29364d9 when an http/2-related bug was fixed, and it appears to be a
leftover trace message.

This message should be removed because:
 * it conveys no information to the user
 * it is enabled in the default build (--enable-verbose)
 * it reads like a warning/unexpected condition
 * it is equivalent to "Detected http proto < 2", which is
   not a useful message.
 * it is a time-wasting red-herring for anyone who encounters
   it for the first time while investigating some other, real
   problem.

This commit removes the trace message "Mark bundle as not
supporting multiuse"
bagder
bagder approved these changes Dec 26, 2022
@bagder bagder closed this in 73477d5 Dec 26, 2022
@bagder
Copy link
Member

bagder commented Dec 26, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants