New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl_easy_reset does not reset status code #1017

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
2 participants
@jay
Member

jay commented Sep 20, 2016

Running curl_easy_reset() on a handle does not reset CURLINFO_RESPONSE_CODE and CURLINFO_FILETIME to their original value (0 and "1970-01-01 01:00:00 CET" respectively) as promised by documentation.

@jay

This comment has been minimized.

Member

jay commented Sep 16, 2016

It looks like PureInfo is not reset in curl_easy_reset. It would probably be safer (and a little slower I bet) to just init a new handle and then copy over only what is documented. Anyway, tabling that for now, try this
edit: moved to https://github.com/curl/curl/compare/master...jay:fix_pureinfo_reset?expand=1

jay added a commit to jay/curl that referenced this pull request Sep 17, 2016

@bagder

This comment has been minimized.

Member

bagder commented Sep 19, 2016

It'd be nice if we could repro this with a test and then verify the fix with it.

@jay

This comment has been minimized.

Member

jay commented Sep 20, 2016

It'd be nice if we could repro this with a test and then verify the fix with it.

Done and I converted this to a PR. BTW I'm curious whether you receive notice when I do that.

@bagder

This comment has been minimized.

Member

bagder commented Sep 20, 2016

No I don't. I think we basically only get notified when there's a comment added which is also why we don't get notified when people for example push a new commit in an existing PR etc

@bagder

bagder approved these changes Sep 20, 2016

ship it! =)

@jay jay merged commit 22cfeac into curl:master Sep 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jay

This comment has been minimized.

Member

jay commented Sep 20, 2016

Thanks Jeroen, landed in 22cfeac.

@jay jay deleted the jay:fix_pureinfo_reset branch Sep 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment