Skip to content

curl_easy_reset does not reset status code - #1017

Merged
jay merged 1 commit into
curl:masterfrom
jay:fix_pureinfo_reset
Sep 20, 2016
Merged

jay merged 1 commit into
curl:masterfrom
jay:fix_pureinfo_reset

Conversation

@jay

@jay jay commented Sep 20, 2016

Copy link
Copy Markdown
Member

Running curl_easy_reset() on a handle does not reset CURLINFO_RESPONSE_CODE and CURLINFO_FILETIME to their original value (0 and "1970-01-01 01:00:00 CET" respectively) as promised by documentation.

@jay

jay commented Sep 16, 2016 •

Copy link
Copy Markdown
Member

It looks like PureInfo is not reset in curl_easy_reset. It would probably be safer (and a little slower I bet) to just init a new handle and then copy over only what is documented. Anyway, tabling that for now, try this
edit: moved to https://github.com/curl/curl/compare/master...jay:fix_pureinfo_reset?expand=1

@bagder

bagder commented Sep 19, 2016

Copy link
Copy Markdown
Member

It'd be nice if we could repro this with a test and then verify the fix with it.

@jay

jay commented Sep 20, 2016

Copy link
Copy Markdown
Member

It'd be nice if we could repro this with a test and then verify the fix with it.

Done and I converted this to a PR. BTW I'm curious whether you receive notice when I do that.

@bagder

bagder commented Sep 20, 2016

Copy link
Copy Markdown
Member

No I don't. I think we basically only get notified when there's a comment added which is also why we don't get notified when people for example push a new commit in an existing PR etc

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it! =)

@jay
jay merged commit 22cfeac into curl:master Sep 20, 2016
@jay

jay commented Sep 20, 2016

Copy link
Copy Markdown
Member

Thanks Jeroen, landed in 22cfeac.

@jay
jay deleted the fix_pureinfo_reset branch September 20, 2016 06:09
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants