pytest suite using httpd+nghttpx, a start by icing · Pull Request #10175 · curl/curl

icing · 2022-12-28T12:52:37Z

Basic infra to run curl against an apache httpd plus nghttpx for h3.

- adding '--with-test-httpd=<path>' to configure non-standard apache2 install
- python env and base classes for running httpd
- basic tests for connectivity with h1/h2/h3

bagder

You added files in docs/examples/* by mistake!

icing · 2022-12-28T16:45:58Z

You added files in docs/examples/* by mistake!

More examples are good! (removed them again, sorry)

sonatype-lift · 2023-01-03T16:05:08Z

Invalid Exception: Expression `"unknown ALPN protocol

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-03T16:05:14Z

💬 9 similar findings have been found in this PR

Invalid type: Expression typing.Optional[typing.List[tests.tests.__sub__(httpd.testenv.certs.CertificateSpec)]] is not a valid type.

🔎 Expand here to view all instances of this finding

File Path Line Number

tests/tests-httpd/testenv/certs.py 118

tests/tests-httpd/testenv/certs.py 164

tests/tests-httpd/testenv/certs.py 167

tests/tests-httpd/testenv/certs.py 188

tests/tests-httpd/testenv/certs.py 192

tests/tests-httpd/testenv/certs.py 196

tests/tests-httpd/testenv/certs.py 196

tests/tests-httpd/testenv/certs.py 200

tests/tests-httpd/testenv/certs.py 200

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-03T16:05:16Z

💬 12 similar findings have been found in this PR

Incompatible variable type: issuer is declared to have type Credentials but is used as type None.

🔎 Expand here to view all instances of this finding

File Path Line Number

tests/tests-httpd/testenv/certs.py 356

tests/tests-httpd/testenv/certs.py 356

tests/tests-httpd/testenv/certs.py 356

tests/tests-httpd/testenv/certs.py 372

tests/tests-httpd/testenv/certs.py 373

tests/tests-httpd/testenv/certs.py 376

tests/tests-httpd/testenv/certs.py 446

tests/tests-httpd/testenv/certs.py 471

tests/tests-httpd/testenv/curl.py 46

tests/tests-httpd/testenv/curl.py 47

Showing 10 of 12 findings. Visit the Lift Web Console to see all.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-03T16:05:18Z

💬 6 similar findings have been found in this PR

Incompatible parameter type: Expected Credentials for 3rd parameter issuer to call CertStore.load_credentials but got None.

🔎 Expand here to view all instances of this finding

File Path Line Number

tests/tests-httpd/testenv/certs.py 340

tests/tests-httpd/testenv/certs.py 344

tests/tests-httpd/testenv/certs.py 388

tests/tests-httpd/testenv/certs.py 482

tests/tests-httpd/testenv/certs.py 522

tests/tests-httpd/testenv/curl.py 240

Visit the Lift Web Console to find more details in your report.

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-01-09T11:18:10Z

Incompatible parameter type: Expected `Variable[typing.AnyStr <

ℹ️ Learn about @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

icing · 2023-01-09T13:44:55Z

If CI works through this, I think it is a good first version to merge.

- adding '--with-test-httpd=<path>' to configure non-standard apache2 install - python env and base classes for running httpd - basic tests for connectivity with h1/h2/h3 - adding test cases for truncated responses in http versions. - adding goaway test for HTTP/3. - adding "stuttering" tests with parallel downloads in chunks with varying delays between chunks. - adding a curltest module to the httpd server, adding GOAWAY test. - mod_curltest now installs 2 handlers - 'echo': writing as response body what came as request body - 'tweak': with query parameters to tweak response behaviour - marked known fails as skip for now

bagder · 2023-01-09T16:44:07Z

Thanks!

…ttpx for h3 - adding '--with-test-httpd=<path>' to configure non-standard apache2 install - python env and base classes for running httpd - basic tests for connectivity with h1/h2/h3 - adding test cases for truncated responses in http versions. - adding goaway test for HTTP/3. - adding "stuttering" tests with parallel downloads in chunks with varying delays between chunks. - adding a curltest module to the httpd server, adding GOAWAY test. - mod_curltest now installs 2 handlers - 'echo': writing as response body what came as request body - 'tweak': with query parameters to tweak response behaviour - marked known fails as skip for now Closes curl#10175

sonatype-lift bot reviewed Dec 28, 2022

View reviewed changes

Comment thread tests/httpd/testenv/curl.py Outdated

sonatype-lift bot reviewed Dec 28, 2022

View reviewed changes

Comment thread tests/httpd/testenv/curl.py Outdated

sonatype-lift bot reviewed Dec 28, 2022

View reviewed changes

Comment thread tests/httpd/testenv/certs.py Outdated

sonatype-lift bot reviewed Dec 28, 2022

View reviewed changes

Comment thread tests/httpd/testenv/certs.py Outdated

bagder requested changes Dec 28, 2022

View reviewed changes

andy5995 reviewed Dec 28, 2022

View reviewed changes

Comment thread tests/httpd/config.ini.in Outdated

andy5995 reviewed Dec 28, 2022

View reviewed changes

Comment thread tests/httpd/conftest.py Outdated

Comment thread tests/httpd/test_01_basic.py Outdated

Comment thread tests/httpd/testenv/__init__.py Outdated

Comment thread tests/httpd/testenv/__init__.py Outdated

sonatype-lift bot reviewed Dec 28, 2022

View reviewed changes

Comment thread tests/httpd/testenv/certs.py Outdated

icing requested a review from bagder December 29, 2022 08:00

bagder reviewed Dec 29, 2022

View reviewed changes

Comment thread .github/scripts/spellcheck.words Outdated

sonatype-lift bot reviewed Dec 29, 2022

View reviewed changes

Comment thread tests/httpd/testenv/curl.py Outdated

sonatype-lift bot reviewed Dec 29, 2022

View reviewed changes

Comment thread tests/httpd/testenv/curl.py Outdated

icing force-pushed the httpd-tests branch from fa778c0 to 3995ab7 Compare January 3, 2023 15:46

sonatype-lift bot reviewed Jan 3, 2023

View reviewed changes