Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional condition for including stdint.h in lib/http.h #10185

Closed
wants to merge 1 commit into from

Conversation

camblomquist
Copy link
Contributor

stdint.h was only included in http.h when ENABLE_QUIC was defined, but symbols from stdint.h are also used when USE_NGHTTP2 is defined. This causes build errors when USE_NGHTTP2 is defined but ENABLE_QUIC is not.

I don't know if such a configuration should be possible, but I had a friend encounter it while building media-autobuild_suite.

Fixes m-ab-s/media-autobuild_suite#2353

stdint.h was only included in http.h when ENABLE_QUIC was defined, but symbols from stdint.h are also used when USE_NGHTTP2 is defined. This causes build errors when USE_NGHTTP2 is defined but ENABLE_QUIC is not.
bagder
bagder approved these changes Dec 31, 2022
@bagder
Copy link
Member

bagder commented Dec 31, 2022

Thanks!

@bagder bagder closed this in 9932701 Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple errors running make when git update for curl
2 participants