http: Decode transfer encoding first #10187
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The unencoding stack is added to as
Transfer-Encoding
andContent-Encoding
fields are encountered with no distinction between the two, meaning the stack will be incorrect if, e.g., the message has both fields and a non-chunkedTransfer-Encoding
comes first. This PR fixes this by ordering the stack with transfer encodings first.Additionally, something I did not change but I think may be a bug is that
MAX_ENCODE_STACK
doesn't limitwriter_stack
's length, just the number of encodings in a single field line.