Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtest.pl: add expected fourth return value #10206

Closed
wants to merge 1 commit into from

Conversation

scrtt
Copy link
Contributor

@scrtt scrtt commented Jan 2, 2023

Fixes warning in autobild log: "Use of uninitialized value $HTTP2TLSPORT in substitution iterator at /tests/runtests.pl line 3516"

Fixes warning in autobild log: "Use of uninitialized value
$HTTP2TLSPORT in substitution iterator at /tests/runtests.pl
line 3516"
@MarcelRaad MarcelRaad self-assigned this Jan 2, 2023
bagder
bagder approved these changes Jan 2, 2023
@bagder bagder added the tests label Jan 2, 2023
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bagder
Copy link
Member

bagder commented Jan 2, 2023

Thanks!

@bagder bagder closed this in 7baff01 Jan 2, 2023
@MarcelRaad
Copy link
Member

This is a regression from commit c7fb341. Is there anything we could do to make this visible in the PRs instead of the autobuilds? I remember similar warnings like this in the past.

@bagder
Copy link
Member

bagder commented Jan 2, 2023

Yeah, they are however "just" warnings so the tests still work fine. A quick googling showed me a trick on how we can "promote" these warnings to errors, which should make them more noticeable. I'll try it in a PR!

bagder added a commit that referenced this pull request Jan 2, 2023
To help us detect and fix warnings in this script easier and faster.

Ref: #10206
bagder added a commit that referenced this pull request Jan 3, 2023
To help us detect and fix warnings in this script easier and faster.

Assisted-by: Jakob Hirsch

Ref: #10206
Closes #10208
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants