Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Replace Curl_addrinfo references at connectdata and filters #10213

Closed
wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Jan 3, 2023

Keep sockaddr local in the socket filters.

  • copy struct Curl_addrinfo on filter setup into context

  • replace struct Curl_addrinfo * with struct Curl_sockaddr_ex * in connectdata that is set and NULLed by the socket filter

  • this means we have no reference to the resolver info in connectdata or its filters

  • trigger the CF_CTRL_CONN_INFO_UPDATE event when the complete filter chain reaches connected status

  • update easy handle connection information on CF_CTRL_DATA_SETUP event.

- copy `struct Curl_addrinfo` on filter setup into context
- remoove `struct Curl_addrinfoi *` with `struct Curl_sockaddr_ex *` in connectdata
  that is set and NULLed by the socket filter
- this means we have no reference to the resolver info in connectdata or its filters

- trigger the CF_CTRL_CONN_INFO_UPDATE event when the complete filter chain
  reaches connected status
- update easy handle connection information on CF_CTRL_DATA_SETUP event.
@icing icing requested a review from bagder Jan 3, 2023
bagder
bagder approved these changes Jan 3, 2023
@bagder bagder closed this in 6a8d7ef Jan 3, 2023
@bagder
Copy link
Member

bagder commented Jan 3, 2023

Thanks!

ryandesign added a commit to ryandesign/curl that referenced this pull request Jan 26, 2023
Remove remaining references to conn and sockfd, which were removed from
the function signature when conninfo_remote was renamed to
conn_set_primary_ip in 6a8d7ef.

See curl#10213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants