Remove/Replace Curl_addrinfo references at connectdata and filters #10213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- copy `struct Curl_addrinfo` on filter setup into context - remoove `struct Curl_addrinfoi *` with `struct Curl_sockaddr_ex *` in connectdata that is set and NULLed by the socket filter - this means we have no reference to the resolver info in connectdata or its filters - trigger the CF_CTRL_CONN_INFO_UPDATE event when the complete filter chain reaches connected status - update easy handle connection information on CF_CTRL_DATA_SETUP event.
bagder
approved these changes
Jan 3, 2023
|
Thanks! |
ryandesign
added a commit
to ryandesign/curl
that referenced
this pull request
Jan 26, 2023
Remove remaining references to conn and sockfd, which were removed from the function signature when conninfo_remote was renamed to conn_set_primary_ip in 6a8d7ef. See curl#10213
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- copy `struct Curl_addrinfo` on filter setup into context - remove `struct Curl_addrinfoi *` with `struct Curl_sockaddr_ex *` in connectdata that is set and NULLed by the socket filter - this means we have no reference to the resolver info in connectdata or its filters - trigger the CF_CTRL_CONN_INFO_UPDATE event when the complete filter chain reaches connected status - update easy handle connection information on CF_CTRL_DATA_SETUP event. Closes curl#10213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep sockaddr local in the socket filters.
copy
struct Curl_addrinfoon filter setup into contextreplace
struct Curl_addrinfo *withstruct Curl_sockaddr_ex *in connectdata that is set and NULLed by the socket filterthis means we have no reference to the resolver info in connectdata or its filters
trigger the CF_CTRL_CONN_INFO_UPDATE event when the complete filter chain reaches connected status
update easy handle connection information on CF_CTRL_DATA_SETUP event.