Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: set SOVERSION also for macOS #10214

Closed
wants to merge 1 commit into from
Closed

cmake: set SOVERSION also for macOS #10214

wants to merge 1 commit into from

Conversation

rbrich
Copy link
Contributor

@rbrich rbrich commented Jan 3, 2023

#10023 added support for SOVERSION in CMake, which is great. But Mac is missing in the listed platforms. It works fine on Mac and it matches the Autotools output, which also sets the soversion.

The installed libs I get after adding Darwin to the list:

libcurl.4.8.0.dylib
libcurl.4.dylib -> libcurl.4.8.0.dylib
libcurl.dylib -> libcurl.4.dylib

I think this is correct.

@bagder bagder added the cmake label Jan 3, 2023
bagder
bagder approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@bagder
Copy link
Member

bagder commented Jan 3, 2023

Thanks!

@bagder bagder closed this in 3ef31a1 Jan 3, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@rbrich @bch
cmake: set SOVERSION also for macOS
dbb77bb 
Closes curl#10214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
cmake
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbrich @bagder