Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noproxy: support for space-separated names is deprecated #10215

Closed
wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 3, 2023

To be removed in July 2024.

Fixes #10209

To be removed in July 2024.

Assisted-by: Michael Osipov
Fixes #10209
Closes #10215
@bagder bagder force-pushed the bagder/deprecate-noproxy-spacesep branch from f4a1ff4 to 5196719 Compare January 3, 2023 14:07
Copy link
Contributor

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two issues here:

osipovmi@deblndw011x:~/var/Projekte/curl (bagder/deprecate-noproxy-spacesep %=)
$ curl --verbose https://deblndw011x.ad001.siemens.net -k
* STATE: INIT => CONNECT handle 0x803d42808; line 1908 (connection #-5000)
* Uses proxy env variable NO_PROXY == 'localhost,.siemens.net .siemens.com .siemens.de'
* Added connection 0. The cache now contains 1 members
* STATE: CONNECT => RESOLVING handle 0x803d42808; line 1954 (connection #0)
  • The message is only visible when --verbose has been provided
  • The message is only visible when the parser has hit this, so not the entire string is consumed. See my mixed case.

But:

osipovmi@deblndw011x:~/var/Projekte/curl (bagder/deprecate-noproxy-spacesep %=)
$ curl --verbose https://deblndw011x.ad001.siemens.net -k
* STATE: INIT => CONNECT handle 0x803d42808; line 1908 (connection #-5000)
* Uses proxy env variable NO_PROXY == 'localhost .siemens.net .siemens.com .siemens.de'
* space-separated NOPROXY patterns are deprecated
* Added connection 0. The cache now contains 1 members

I guess both are intentional.

@bagder
Copy link
Member Author

bagder commented Jan 3, 2023

The message is only visible when --verbose has been provided

Yes. We have no habit of showing libcurl warnings more visible than this. I understand that this makes the warning a little hard to spot, but I think we can live with that.

The message is only visible when the parser has hit this, so not the entire string is consumed.

Yes, I realized this as well, but the parser does not go further than it needs to, so it does not know if there are space-separators later in the string, and adding an extended check solely for the purpose of adding the warning seemed like a like unnecessary.

Copy link
Contributor

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both limitations are acceptable for me.

@bagder bagder closed this in 7ad8a7b Jan 4, 2023
@bagder bagder deleted the bagder/deprecate-noproxy-spacesep branch January 4, 2023 08:16
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
To be removed in July 2024.

Assisted-by: Michael Osipov
Fixes curl#10209
Closes curl#10215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants