Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nss: implement data_pending method #10225

Closed
wants to merge 1 commit into from

Conversation

monnerat
Copy link
Contributor

@monnerat monnerat commented Jan 4, 2023

NSS currently uses the default Curl_none_data_pending() method which always returns false, causing TLS buffered input data to be missed.

The current commit implements the nss_data_pending() method that properly monitors the presence of available TLS data.

Other backends should be checked (and fixed) for possible similar problems.

@monnerat monnerat marked this pull request as draft Jan 4, 2023
bagder
bagder approved these changes Jan 4, 2023
@monnerat monnerat force-pushed the nssdatapending branch 3 times, most recently from c35b8f4 to ada65c9 Compare Jan 5, 2023
@monnerat monnerat marked this pull request as ready for review Jan 5, 2023
NSS currently uses the default Curl_none_data_pending() method which
always returns false, causing TLS buffered input data to be missed.

The current commit implements the nss_data_pending() method that properly
monitors the presence of available TLS data.

Ref:curl#10077
@bagder
Copy link
Member

bagder commented Jan 7, 2023

Thanks!

@bagder bagder closed this in ee0f739 Jan 7, 2023
@monnerat monnerat deleted the nssdatapending branch Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants