improved debug logging for cfilters #10271
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| case CURLINFO_HEADER_OUT: | ||
| case CURLINFO_HEADER_IN: | ||
| fwrite(s_infotype[type], 2, 1, data->set.err); | ||
| fwrite(ptr, size, 1, data->set.err); |
Check failure
Code scanning / CodeQL
Cleartext storage of sensitive information in file
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
…ons.
- new functions and macros for cfilter debugging
- set CURL_DEBUG with names of cfilters where debug logging should be enabled
- use GNUC __attribute__ to enable printf format checks during compile
…se non-C99, non-debug builds.
…such calls in non-debug mode.
| CF_DEBUGF(infof(data, CFMSG(cf, "recv(len=%zu) -> %d, err=%d"), | ||
| len, (int)nread, *err)); | ||
| DEBUGF(LOG_CF(data, cf, "recv(len=%zu) -> %d, err=%d", len, (int)nread, | ||
| *err)); |
There was a problem hiding this comment.
I appreciate why this may be necessary temporarily, and useful, but even for me this is sometimes too verbose. It looks like this PR is going to change CF logging so that it cannot be disabled on DEBUGBUILDs any longer.
There was a problem hiding this comment.
Theses statements will not produce output, unless you enable the logging for a certain cfilter type.
CURL_DEBUG=tcp curl -v url
will enable the logging of the 'TCP' socket cfilter.
The idea here is to have logging available, should you wish, without recompiling the debug-enabled curl.
There was a problem hiding this comment.
Neat. We will need documentation explaining how it works.
|
Thanks! |
- new functions and macros for cfilter debugging - set CURL_DEBUG with names of cfilters where debug logging should be enabled - use GNUC __attribute__ to enable printf format checks during compile Closes curl#10271
New curl_log.[ch] to keep failf/infof and debug logging implementations.
Usage on a debug build:
Tried to make the macros performant and work for all compilers. Let's see what CI says.