Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL: use local BIO_METHOD instance #10285

Closed
wants to merge 1 commit into from
Closed

Conversation

icing
Copy link
Contributor

@icing icing commented Jan 12, 2023

Make the BIO_METHOD instance a local variable of the OpenSSL connection filter.

This avoids UAF issues when curl_global_cleanup() is called before all transfers have been completely handled.

…on filter.

This avoids UAF issues when `curl_global_cleanup()` is called before all transfers have
been completely handled.
bagder
bagder approved these changes Jan 12, 2023
@bagder bagder added the TLS label Jan 12, 2023
@bagder
Copy link
Member

bagder commented Jan 12, 2023

The Windows CI failures are being addressed here: #10286

@bagder
Copy link
Member

bagder commented Jan 12, 2023

Thanks!

@bagder bagder closed this in 12157aa Jan 12, 2023
pheiduck pushed a commit to pheiduck/curl that referenced this pull request Jan 13, 2023
This avoids UAF issues when `curl_global_cleanup()` is called before all
transfers have been completely handled. Unfortunately this seems to be a
more common pattern than we like.

Closes curl#10285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants