openssl: interop with AWS-LC #10320
openssl: interop with AWS-LC #10320
Conversation
|
I did a force push to fix a LONGLINE formatting error coming from checksrc.pl during the build in CI. |
|
The 6 macOS build failures appear to be pre-existing to this PR and should be resolved by #10288. |
|
This looks fine to me but we are in a feature freeze and not adding new symbols, so this will have to wait until the next feature window opens. |
|
What does this mean in terms of timing before it is able to get into a release? The next one I see on the calendar you provided is in March. I was hoping to be able to get this into 7.88.0 to simplify some near-term plans. Given it was submitted on the day of the freeze and is very low risk, would you consider an exception? |
Given as Daniel is on vacation, I doubt anyone is going to grant an exception to the feature window in his absence. |
|
It looks like I didn't quite get all of the compile-time branches, like OSSL_PACKAGE definition and version printout, and a curl-openssl.m4 section for detecting AWS-LC. |
|
Regarding the feature window, that's fine, we'll let this bake appropriately then, and it will be better when it goes in. |
jeking3
force-pushed
the
awslc-compat
branch
2 times, most recently
from
d79cbb4
to
95d9f49
Compare
|
That line length linter sure is pedantic! |
jeking3
force-pushed
the
awslc-compat
branch
2 times, most recently
from
b90c19d
to
210b166
Compare
|
Rebased to pick up CI improvements. |
|
Rebased to resolve conflicts in READMEs. I see we're down to two failing CI jobs (unrelated to these changes), so it looks like some of those were fixed (or removed) as well. |
* Configure changes to detect AWS-LC * CMakeLists.txt changes to detect AWS-LC * Compile-time branches needed to support AWS-LC * Correctly set OSSL_VERSION and report AWS-LC release number * GitHub Actions script to build with autoconf and cmake against AWS-LC AWS-LC is a BoringSSL/OpenSSL derivative For more information see https://github.com/awslabs/aws-lc/
|
Rebased on master to resolve conflict and pick up CI fixes. |
jeking3
force-pushed
the
awslc-compat
branch
from
5d01a83
to
84b5b80
Compare
| @@ -1015,6 +1015,7 @@ CURLSSH_AUTH_KEYBOARD 7.16.1 | |||
| CURLSSH_AUTH_NONE 7.16.1 | |||
| CURLSSH_AUTH_PASSWORD 7.16.1 | |||
| CURLSSH_AUTH_PUBLICKEY 7.16.1 | |||
| CURLSSLBACKEND_AWSLC 7.88.0 | |||
There was a problem hiding this comment.
This should probably become 8.1.0 as that's the next feature window version.
| AWS-LC | ||
| AWSLC | ||
| aws-lc | ||
| awslc |
There was a problem hiding this comment.
Do we really need to spell it this many different ways? Is there not an official way we could stick to?
|
Thanks! |
* Configure changes to detect AWS-LC * CMakeLists.txt changes to detect AWS-LC * Compile-time branches needed to support AWS-LC * Correctly set OSSL_VERSION and report AWS-LC release number * GitHub Actions script to build with autoconf and cmake against AWS-LC AWS-LC is a BoringSSL/OpenSSL derivative For more information see https://github.com/awslabs/aws-lc/ Closes curl#10320
This pull request adds support for building against AWS-LC.
AWS-LC is a BoringSSL/OpenSSL derivative. For more information see https://github.com/awslabs/aws-lc/
This is my first PR into curl - please let me know if I missed anything or changed something I was not supposed to.
Changes
Testing