New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add a workflow to automatically label pull requests #10326
Conversation
4f2c983
to
77fc5d8
Compare
Actually, the action is running and it did add a CI label! |
.github/labeler.yml
Outdated
- all: ['lib/*win32*'] | ||
- all: ['lib/curl_multibyte.*'] | ||
- all: ['lib/rename.*'] | ||
- all: ['Winbuild/**'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is case sensitive then it is 'winbuild' in lowercase. Also I think it should be added to the build tag if the labeler allows multiple tags to be applied to the same path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done and done.
77fc5d8
to
0170c31
Compare
The labeler language is quite restrictive right now so labels are added quite conservatively, meaning that many PRs won't get labels when it's "obvious" they should. It will still save some manual work on those that it can label.
0170c31
to
a101a1a
Compare
I've added a few more documentation files & build paths. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see what happens.
The labeler language is quite restrictive right now so labels are added quite conservatively, meaning that many PRs won't get labels when it's "obvious" they should. It will still save some manual work on those that it can label.
The first workflow runs ran with GITHUB_TOKEN Permissions PullRequests: write but now they're running with PullRequests: read and failing with the error |
I think that's it. According to the docs, Maximum access for |
what about s/pull_request/pull_request_target like this guy |
Otherwise, the action won't work on PRs from forked repositories (#10326).
I didn't notice that |
The labeler language is quite restrictive right now so labels are added
quite conservatively, meaning that many PRs won't get labels when it's
"obvious" they should. It will still save some manual work on those
that it can label.
If this labeler were already running, it would have labeled this PR with "CI".