cmake: delete redundant macro definition SECURITY_WIN32
#10341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop explicitly defining `SECURITY_WIN32` in CMake builds. No other build system defines this macro, because it is unconditionally defined in `lib/curl_sspi.h` already. This is the only curl source using the `sspi.h` and `security.h` Win32 headers, and no other Win32 headers need this macro. Closes #xxxxx
vszakats
changed the title
SECURITY_WIN32
jay
approved these changes
Jan 25, 2023
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Stop explicitly defining `SECURITY_WIN32` in CMake builds. No other build systems define this macro, because it's unconditionally defined in `lib/curl_sspi.h` already. This is the only curl source using the `sspi.h` and `security.h` Win32 headers, and no other Win32 headers need this macro. Reviewed-by: Jay Satiro Closes curl#10341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop explicitly defining
SECURITY_WIN32in CMake builds.No other build system defines this macro, because it's unconditionally defined in
lib/curl_sspi.halready. This is the only curl source using thesspi.handsecurity.hWin32 headers, and no other Win32 headers need this macro.Closes #xxxxx