Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf-socket: Fix build when not HAVE_GETPEERNAME #10343

Closed
wants to merge 1 commit into from

Conversation

ryandesign
Copy link
Contributor

Remove remaining references to conn and sockfd, which were removed from the function signature when conninfo_remote was renamed to conn_set_primary_ip in 6a8d7ef.

See #10213

Fixes this build failure when building for Classic Mac OS (using a new Makefile I haven't contributed yet):

### MWC68K Compiler Error:
#	(void)conn;
#	      ^^^^
# undefined identifier 'conn'
#----------------------------------------------------------
File "cf-socket.c"; Line 1177
#----------------------------------------------------------
### MWC68K Compiler Error:
#	(void)sockfd;
#	      ^^^^^^
# undefined identifier 'sockfd'
#----------------------------------------------------------
File "cf-socket.c"; Line 1178
#----------------------------------------------------------

Remove remaining references to conn and sockfd, which were removed from
the function signature when conninfo_remote was renamed to
conn_set_primary_ip in 6a8d7ef.

See curl#10213
@jay jay closed this in a17101e Jan 26, 2023
@jay
Copy link
Member

jay commented Jan 26, 2023

Thanks

@ryandesign ryandesign deleted the ryandesign-cf-socket branch January 26, 2023 13:39
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Remove remaining references to conn and sockfd, which were removed from
the function signature when conninfo_remote was renamed to
conn_set_primary_ip in 6a8d7ef.

Closes curl#10343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants