Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket: fix bad assert, unstick shutdown #10366

Closed
wants to merge 4 commits into from
Closed

WebSocket: fix bad assert, unstick shutdown #10366

wants to merge 4 commits into from

Commits on Jan 30, 2023

  1. ws: remove bad assert 

    Reported-by: Stanley Wucw
Fixes #10347
    @bagder
    bagder committed Jan 30, 2023
    Copy the full SHA
    f204b83 View commit details
    Browse the repository at this point in the history

  2. ws: unstick connect-only shutdown 

    As this mode uses blocking sockets, it must set them back to
non-blocking in disconnect to avoid the risk of getting stuck.
    @bagder
    bagder committed Jan 30, 2023
    Copy the full SHA
    1399e3f View commit details
    Browse the repository at this point in the history

  3. fixup non-ws builds

    @bagder
    bagder committed Jan 30, 2023
    Copy the full SHA
    92ec943 View commit details
    Browse the repository at this point in the history

  4. fixup the ws disconnect a little nicer

    @bagder
    bagder committed Jan 30, 2023
    Copy the full SHA
    874bb37 View commit details
    Browse the repository at this point in the history