urlapi: avoid Curl_dyn_addf() for hex outputs #10384
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
inspired by the recent fixes to escape.c, we really should avoid calling Curl_dyn_addf() in loops, perhaps in particular when adding something so simple such as
%HH
codes - for performance reasons. This change thus makes the same thing for the URL parser's two URL-encoding loops.