tool_operate: Fix error code on bad URL #10414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could not spot any other places... |
dfandrich
force-pushed
the
dfandrich/badurl
branch
from
5691a9b to
7983a54
Compare
dfandrich
changed the title
|
I found a couple of other places where the wrong error code might be returned. I've also added a test case to check the original problem. This should be ready now. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bagder
reviewed
Feb 6, 2023
curl would erroneously report CURLE_OUT_OF_MEMORY in some cases instead of CURLE_URL_MALFORMAT. In other cases, it would erroneously return CURLE_URL_MALFORMAT instead of CURLE_OUT_OF_MEMORY. Add a test case to test the former condition. Closes #10130
It would return CURLE_URL_MALFORMAT in an OOM condition.
dfandrich
force-pushed
the
dfandrich/badurl
branch
from
7983a54 to
a5bdc4b
Compare
bagder
approved these changes
Feb 7, 2023
|
Thanks, merged it for you! |
bagder
pushed a commit
that referenced
this pull request
Feb 7, 2023
It would return CURLE_URL_MALFORMAT in an OOM condition. Closes #10414
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
curl would erroneously report CURLE_OUT_OF_MEMORY in some cases instead of CURLE_URL_MALFORMAT. In other cases, it would erroneously return CURLE_URL_MALFORMAT instead of CURLE_OUT_OF_MEMORY. Add a test case to test the former condition. Fixes curl#10130 Closes curl#10414
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
It would return CURLE_URL_MALFORMAT in an OOM condition. Closes curl#10414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: There are probably other cases where a CURLUcode should be
converted into a CURLcode.
Closes #10130