Properly check boundaries in SMB communication #1052

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@stoeckmann
Contributor

Not all reply messages were properly checked for their lengths,
which made it possible to access uninitialized memory (but this does
not lead to out of boundary accesses).

@stoeckmann stoeckmann Properly check boundaries in SMB communication
Not all reply messages were properly checked for their lengths,
which made it possible to access uninitialized memory (but this does
not lead to out of boundary accesses).
f823926
@mention-bot

@stoeckmann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @dfandrich to be potential reviewers.

@stoeckmann
Contributor

Verified this patch by downloading a file via SMB. A careful review is recommended, though.

@bagder bagder added a commit that closed this pull request Oct 8, 2016
@stoeckmann @bagder stoeckmann + bagder smb: properly check incoming packet boundaries
Not all reply messages were properly checked for their lengths, which
made it possible to access uninitialized memory (but this does not lead
to out of boundary accesses).

Closes #1052
8272049
@bagder bagder closed this in 8272049 Oct 8, 2016
@bagder
Member
bagder commented Oct 8, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment