New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check boundaries in SMB communication #1052

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@stoeckmann
Contributor

stoeckmann commented Oct 3, 2016

Not all reply messages were properly checked for their lengths,
which made it possible to access uninitialized memory (but this does
not lead to out of boundary accesses).

Properly check boundaries in SMB communication
Not all reply messages were properly checked for their lengths,
which made it possible to access uninitialized memory (but this does
not lead to out of boundary accesses).
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Oct 3, 2016

@stoeckmann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @dfandrich to be potential reviewers.

mention-bot commented Oct 3, 2016

@stoeckmann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @dfandrich to be potential reviewers.

@stoeckmann

This comment has been minimized.

Show comment
Hide comment
@stoeckmann

stoeckmann Oct 3, 2016

Contributor

Verified this patch by downloading a file via SMB. A careful review is recommended, though.

Contributor

stoeckmann commented Oct 3, 2016

Verified this patch by downloading a file via SMB. A careful review is recommended, though.

@bagder bagder closed this in 8272049 Oct 8, 2016

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Oct 8, 2016

Member

Thanks!

Member

bagder commented Oct 8, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment