Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check boundaries in SMB communication #1052

Closed
wants to merge 1 commit into from

Conversation

@stoeckmann
Copy link
Contributor

@stoeckmann stoeckmann commented Oct 3, 2016

Not all reply messages were properly checked for their lengths,
which made it possible to access uninitialized memory (but this does
not lead to out of boundary accesses).

Not all reply messages were properly checked for their lengths,
which made it possible to access uninitialized memory (but this does
not lead to out of boundary accesses).
@mention-bot
Copy link

@mention-bot mention-bot commented Oct 3, 2016

@stoeckmann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @dfandrich to be potential reviewers.

@stoeckmann
Copy link
Contributor Author

@stoeckmann stoeckmann commented Oct 3, 2016

Verified this patch by downloading a file via SMB. A careful review is recommended, though.

@bagder bagder closed this in 8272049 Oct 8, 2016
@bagder
Copy link
Member

@bagder bagder commented Oct 8, 2016

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
@bagder bagder added the SMB label May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.