Skip to content

HTTP/2 buffer/pausedata and outpu flush fix. #10529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

HTTP/2 buffer/pausedata and outpu flush fix. #10529

wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Feb 15, 2023

  • do not process pending input data when copying pausedata to the caller
  • return CURLE_AGAIN if the output buffer could not be completely written out.

Refs #10525.

@icing
HTTP/2 buffer/pausedata and outpu flush fix.
7bb5f47 
 * do not process pending input data when copying pausedata to the caller
 * return CURLE_AGAIN if the output buffer could not be completely written out.
@icing icing mentioned this pull request Feb 15, 2023
Closed
@eworm-de
Copy link
Contributor

eworm-de commented Feb 15, 2023 •
edited
Loading

Your commit message has a typo. 😜

s/outpu/output/

@eworm-de
Copy link
Contributor

With this change applied on top of 7.88.0 I can no longer reproduce this issue.
Thanks a lot for investigating and fixing!

@eworm-de
Copy link
Contributor

The first commit still causes trouble... Will try with the second one tomorrow.

@piru piru mentioned this pull request Feb 16, 2023
Closed
@bagder bagder closed this in 3103de2 Feb 16, 2023
bagder pushed a commit that referenced this pull request Feb 16, 2023
@bagder
http2: set drain on stream end
87ed650 
Ensure that on_frame_recv() stream end will trigger a read if there is
pending data. Without this it could happen that the pending data is
never consumed.

This combined with #10529 should fix
#10525

Ref: #10525
Closes #10530
@bagder
Copy link
Member

bagder commented Feb 16, 2023

Thanks!

bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@icing @bch
http2: buffer/pausedata and output flush fix.
d8870de 
 * do not process pending input data when copying pausedata to the
   caller
 * return CURLE_AGAIN if the output buffer could not be completely
   written out.

Ref: curl#10525
Closes curl#10529
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
@bch
http2: set drain on stream end
ff7e8a6 
Ensure that on_frame_recv() stream end will trigger a read if there is
pending data. Without this it could happen that the pending data is
never consumed.

This combined with curl#10529 should fix
curl#10525

Ref: curl#10525
Closes curl#10530
@basuke basuke mentioned this pull request Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
HTTP HTTP/2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icing @eworm-de @bagder