Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsedate without sscanf #10547

Closed
wants to merge 4 commits into from
Closed

parsedate without sscanf #10547

wants to merge 4 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 17, 2023

sscanf() is complex and slow, and we can avoid doing copies

- sscanf is slow and complex, avoid it
- give up already if the string is 12 bytes or longer as no valid string
  can be that long
- this can now be done without copy
@bagder
Copy link
Member Author

bagder commented Feb 17, 2023

I'm holding this until after 7.88.1

@bagder bagder closed this in ba9a4e9 Feb 20, 2023
bagder added a commit that referenced this pull request Feb 20, 2023
@bagder bagder deleted the bagder/parsedate-wo-sscanf branch February 20, 2023 22:49
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
- sscanf is slow and complex, avoid it
- give up already if the string is 12 bytes or longer as no valid string
  can be that long
- this can now be done without copy

Closes curl#10547
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant