Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP/{2,3} test fixes. #10568

Closed
wants to merge 3 commits into from
Closed

HTTP/{2,3} test fixes. #10568

wants to merge 3 commits into from

Conversation

Kangie
Copy link
Contributor

@Kangie Kangie commented Feb 20, 2023

  • Rename tests/httpserver.pl -> tests/http-server.pl to be consistent with http{2,3}-server.pl
  • add tests/http3-server.pl to distribution tarball
  • replace getcwd() in http{2,3}-server.pl to fix out-of-tree tests.

@github-actions github-actions bot added the tests label Feb 20, 2023
@Kangie
Copy link
Contributor Author

Kangie commented Feb 20, 2023

I'm not going to touch it here, but the HTTP/2 and HTTP/3 proxy perl scripts could probably be consolidated - they're basically copy-pasted; a single httpx-proxy.pl with a conditional for the version of HTTP would probably be more sane than maintaining two (almost) identical invocations of the same proxy!

@Kangie Kangie changed the title HTTP2/3 test fixes. HTTP/{2,3} test fixes. Feb 20, 2023
@bagder
Copy link
Member

bagder commented Feb 20, 2023

Thanks!

@bagder bagder closed this in cbf5717 Feb 20, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
- httpserver.pl -> http-server.pl for consistency
- add http3-server.pl to EXTRA_DIST; alphabetise for maintainability
- nghttpx proxy invocation scripts should not use getcwd

Closes curl#10568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants