Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPRECATE: the original legacy mingw version 1 #10667

Closed
wants to merge 4 commits into from
Closed

DEPRECATE: the original legacy mingw version 1 #10667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
275d951
DEPRECATE: the original legacy mingw version 1
bagder Mar 3, 2023
6f842e4
fixup spelling
bagder Mar 3, 2023
74cf1a4
fixup DEBUG configure to detect all msys v1
bagder Mar 3, 2023
3449c50
.azure-pipelines.yml: enable mingw legacy with configure option
bagder Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure-pipelines.yml
View file
Open in desktop
Expand Up @@ -223,7 +223,7 @@ stages:
name: 32-bit (legacy)
container_img: ghcr.io/mback2k/curl-docker-winbuildenv/msys1-mingw:ltsc2019
container_cmd: C:\MinGW\msys\1.0\bin\sh
configure: --host=i686-pc-mingw32 --build=i686-pc-mingw32 --prefix=/mingw --enable-debug --without-ssl
configure: --host=i686-pc-mingw32 --build=i686-pc-mingw32 --prefix=/mingw --enable-debug --without-ssl --with-mingw1-deprecated
tests: "!203 !1143"
v1_mingw32:
name: 32-bit w/o zlib
Expand Down Expand Up @@ -255,7 +255,7 @@ stages:
name: 32-bit Schannel/SSPI/WinIDN (legacy)
container_img: ghcr.io/mback2k/curl-docker-winbuildenv/msys1-mingw:ltsc2019
container_cmd: C:\MinGW\msys\1.0\bin\sh
configure: --host=i686-pc-mingw32 --build=i686-pc-mingw32 --prefix=/mingw --enable-debug --enable-sspi --with-schannel --with-winidn
configure: --host=i686-pc-mingw32 --build=i686-pc-mingw32 --prefix=/mingw --enable-debug --enable-sspi --with-schannel --with-winidn --with-mingw1-deprecated
tests: "!203 !305 !311 !312 !313 !404 !1143 !2033 !2035 !2038 !2041 !2042 !2048 !2070 !2079 !2087 !3023 !3024"
v1_mingw32_schannel:
name: 32-bit Schannel/SSPI/WinIDN w/o zlib
Expand Down
15 changes: 14 additions & 1 deletion configure.ac
View file
Open in desktop
Expand Up @@ -612,13 +612,26 @@ case $host in
]])
],[
curl_mingw_original=yes
curl_mingw_die=yes
AC_MSG_RESULT([yes])
],[
AC_MSG_RESULT([no])
AC_MSG_RESULT([no: $host])
])
;;
esac


AC_ARG_WITH(mingw1-deprecated,dnl
AS_HELP_STRING([--with-mingw1-deprecated],[confirm you realize support for mingw v1 is dying]),
if test X"$withval" != Xno; then
curl_mingw_die=
fi
)

if test -n "$curl_mingw_die"; then
AC_MSG_ERROR([support for mingw v1 is going away, enable temporarily with --with-mingw1-deprecated])
fi

dnl **********************************************************************
dnl Compilation based checks should not be done before this point.
dnl **********************************************************************
Expand Down
12 changes: 12 additions & 0 deletions docs/DEPRECATE.md
View file
Open in desktop
Expand Up @@ -31,6 +31,18 @@ We remove support for building curl with the gskit TLS library in August 2023.
- build breakages in this code take weeks or more to get detected
- fixing gskit code is mostly done "flying blind"

## mingw v1

We remove support for building curl with the original legacy mingw version 1
in September 2023.

During the deprecation period you can enable the support with the configure
option `--with-mingw1-deprecated`.

mingw version 1 is old and deprecated software. There are much better and
still support build environments to use to build curl and other software. For
example [MinGW-w64](https://www.mingw-w64.org/).

## space-separated `NOPROXY` patterns

When specifying patterns/domain names for curl that should *not* go through a
Expand Down