tool: dump headers even if file is write-only #10675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixes in curl#10079 brought a (seemingly unrelated) change of open mode from `wb`/`ab` to `wb+`/`ab+` for the headerfile. This makes it no longer possible to write the header file to e.g. a pipe, like: curl -D >(grep ...) file:///dev/null Which presently results in `Warning: Failed to open /dev/fd/63` See curl#10079 Closes curl#10675
algorythmic
force-pushed
the
header-file-write-only
branch
from
f03f01c to
2a15bd2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -983,11 +983,11 @@ | |||
| * for every transfer. | |||
| */ | |||
| if(!per->prev || per->prev->config != config) { | |||
| newfile = fopen(config->headerfile, "wb+"); | |||
| newfile = fopen(config->headerfile, "wb"); | |||
Check failure
Code scanning / CodeQL
File created without restricting permissions
| if(newfile) | ||
| fclose(newfile); | ||
| } | ||
| newfile = fopen(config->headerfile, "ab+"); | ||
| newfile = fopen(config->headerfile, "ab"); |
Check failure
Code scanning / CodeQL
File created without restricting permissions
bagder
approved these changes
Mar 6, 2023
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
The fixes in curl#10079 brought a (seemingly unrelated) change of open mode from `wb`/`ab` to `wb+`/`ab+` for the headerfile. This makes it no longer possible to write the header file to e.g. a pipe, like: curl -D >(grep ...) file:///dev/null Which presently results in `Warning: Failed to open /dev/fd/63` See curl#10079 Closes curl#10675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes in #10079 brought a (seemingly unrelated) change of open mode from
wb/abtowb+/ab+for the headerfile. This makes it no longer possible to write the header file to e.g. a pipe, like:Which presently results in
Warning: Failed to open /dev/fd/63See #10079
Closes #10675