Makefile.mk: delete redundant HAVE_LDAP_SSL macro [ci skip]
#10681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since abebb2b, we set this macro for all Windows `wldap32` builds using `Makefile.mk`. For OpenLDAP builds this macro is not enough to enable LDAPS, and OpenLDAP is not an option in `Makefile.mk`. For Novell LDAP it might have helped, but it's also not an option anymore in `Makefile.mk`. Either way the future for LDAPS is that we should enable them by default without extra build knobs.
MarcelRaad
approved these changes
Mar 5, 2023
vszakats
changed the title
HAVE_LDAP_SSL macro [ci skip]
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Mar 7, 2023
This has been the default since this curl commit: curl/curl@abebb2b Upcoming curl 8.0.0 will ignore the `-ldaps` option: curl/curl@8d0fa3a curl/curl#10681
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
Since abebb2b, we set this macro for all Windows `wldap32` builds using `Makefile.mk`. For OpenLDAP builds this macro is not enough to enable LDAPS, and OpenLDAP is not an option in `Makefile.mk`. For Novell LDAP it might have helped, but it's also not an option anymore in `Makefile.mk`. The future for LDAPS is that we should enable it by default without extra build knobs. Reviewed-by: Marcel Raad Closes curl#10681
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since abebb2b, we set this macro for all Windows
wldap32builds usingMakefile.mk.For OpenLDAP builds this macro is not enough to enable LDAPS, and OpenLDAP is not an option in
Makefile.mk. For Novell LDAP it might have helped, but it's also not an option anymore inMakefile.mk.The future for LDAPS is that we should enable it by default without extra build knobs.
Closes #10681