Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: note '--data-urlencode' option #10687

Closed
wants to merge 1 commit into from

Conversation

andy5995
Copy link
Contributor

@andy5995 andy5995 commented Mar 6, 2023

No description provided.

@bagder
Copy link
Member

bagder commented Mar 6, 2023

I suppose we call it "URL encode" in plain English?

@@ -810,6 +810,7 @@ URI
URIs
url
URL's
urlencode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. This is not an English word. You would write it as URL encode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll make the change. But 'urlencoded' is used elsewhere in the document and already on the whitelist.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed. But I think maybe those should rather be fixed as well at some point?

bagder
bagder approved these changes Mar 6, 2023
@bagder
Copy link
Member

bagder commented Mar 6, 2023

Thanks!

@bagder bagder closed this in 7c3822f Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants