Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic in connection reuse to deny reuse on "unclean" connections #10690

Closed
wants to merge 2 commits into from

Conversation

icing
Copy link
Contributor

@icing icing commented Mar 6, 2023

  • add parameter to conn_is_alive() cfilter method that returns if there is input data waiting on the connection
  • refrain from re-using connnection from the cache that have input pending
  • adapt http/2 and http/3 alive checks to digest pending input to check the connection state
  • remove check_cxn method from openssl as that was just doing what the socket filter now does.
  • add tests for connection reuse with special server configs

Refs #10646

@bagder
Copy link
Member

bagder commented Mar 6, 2023

merge conflicts, can you please take a look?

- add parameter to `conn_is_alive()` cfilter method that returns
  if there is input data waiting on the connection
- refrain from re-using connnection from the cache that have
  input pending
- adapt http/2 and http/3 alive checks to digest pending input
  to check the connection state
- remove check_cxn method from openssl as that was just doing
  what the socket filter now does.
- add tests for connection reuse with special server configs
- msh3: fix parameter type wrong in is_alive check
- nss, securetransport: remove own `check_cxn` method, as
  other TLS backends also no longer do their own.
@bagder
Copy link
Member

bagder commented Mar 7, 2023

Thanks!

@bagder bagder closed this in 7c5637b Mar 7, 2023
bch pushed a commit to bch/curl that referenced this pull request Jul 19, 2023
…ions

- add parameter to `conn_is_alive()` cfilter method that returns
  if there is input data waiting on the connection
- refrain from re-using connnection from the cache that have
  input pending
- adapt http/2 and http/3 alive checks to digest pending input
  to check the connection state
- remove check_cxn method from openssl as that was just doing
  what the socket filter now does.
- add tests for connection reuse with special server configs

Closes curl#10690
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants