/ curl Public
doc: fix compiler warning in libcurl.m4 #10710
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Current test for
curl_free()may produce warnings with strict compiler flags or even with default compiler flags with upcoming versions like this:
These warning could turned into errors by
-Werroror similar flags.
Such warnings/errors are avoided by this patch.
With this patch the check is based on header, not libcurl binary, but having different versions of libcurl binary and libcurl header could easily lead to many various problems, so quick failure on build-time (if
curl_free()is present in header, but absent in the library binary) could be a better option then hard-to-debug failures on run-time.